Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appium driver #85

Merged
merged 21 commits into from
Feb 19, 2025
Merged

Add appium driver #85

merged 21 commits into from
Feb 19, 2025

Conversation

tzvielwix
Copy link
Contributor

No description provided.

LironMShemen and others added 10 commits February 12, 2025 16:34
The app contains 3 screens: emoji game, colors game, assertions screen
- "Import" the driver from the Detox project
- Add Detox id injection
- Remove native matchers and clarify the importance of using "by id"
- Add prompt handler to the package
- Add Pilot tests for each screen
@tzvielwix tzvielwix requested a review from asafkorem February 18, 2025 08:10
Copy link
Collaborator

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really exciting 😀

@tzvielwix tzvielwix requested a review from asafkorem February 18, 2025 13:22
asafkorem
asafkorem previously approved these changes Feb 18, 2025
Copy link
Collaborator

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Small comment, besides that, approved 💚

@asafkorem asafkorem merged commit 5e7a282 into master Feb 19, 2025
3 checks passed
@asafkorem asafkorem deleted the add-appium-driver branch February 19, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants