Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update - from patch to fully replace #387

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Idokah
Copy link
Collaborator

@Idokah Idokah commented Jan 11, 2023

Delete prepareItemForUpdate and use prepareItemForInsert instead.

For collection with this schema: _id, fieldA, fieldB, update request with this item:
{_id: '..', fieldA: 'whatEver'}, will become in prepareItemsForInsert to :
{_id: '.., fieldA: 'whatEver', fieldB: null}

Until now, this kind of request would only update the fields that the object contains and not override the others.

fixing this issue: https://github.com/wix-private/auto-views/issues/7095

@Idokah Idokah added the don't merge Don't merge this PR label Jan 22, 2023
@Idokah
Copy link
Collaborator Author

Idokah commented Jan 22, 2023

Will merge after merging #393 to avoid conflicts.

@Idokah Idokah removed the don't merge Don't merge this PR label Feb 22, 2023
@Idokah Idokah added the don't merge Don't merge this PR label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Don't merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants