Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the way SQL request are handled #2

Open
ecourtial opened this issue Jan 27, 2020 · 0 comments
Open

Improve the way SQL request are handled #2

ecourtial opened this issue Jan 27, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ecourtial
Copy link
Collaborator

Following @ArthurHoaro comment:

I didn't really take a deep look at the implementation, but it looks like that there is a lot of code for SQL query building.
As a further improvement, maybe it would make sense to use a proper SQL query builder as a dependency rather than implementing one in this lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArthurHoaro @ecourtial