Use php74 property type hints #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdebisschop
commented
Dec 23, 2020
kdebisschop
commented
Dec 23, 2020
kdebisschop
commented
Dec 23, 2020
kdebisschop
commented
Dec 23, 2020
|
Nice PR ! We are going to check it in details next week :) |
|
Nice huge work :) |
kdebisschop
force-pushed
the
use-php74-property-type-hints
branch
from
f6f4f18
to
37d1fe1
Compare
leNEKO
previously approved these changes
Jan 10, 2021
Nicolas-Masson-Wizaplace
previously approved these changes
Jan 10, 2021
kdebisschop
dismissed stale reviews from Nicolas-Masson-Wizaplace and leNEKO
via
e1323ce
ecourtial
previously approved these changes
Jan 15, 2021
|
Need rebase :) |
kdebisschop
force-pushed
the
use-php74-property-type-hints
branch
from
e1323ce
to
8fa4c2f
Compare
|
@ecourtial rebased |
ecourtial
approved these changes
Feb 12, 2021
|
@Nicolas-Masson-Wizaplace If it is ok for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a large backward-compatibility breaking patch proposal to start work on a v2 release.
Resolves #70