add deprecation message for allow_resource_tags_on_deletion in google…

…_bigquery_table
wj-chen · Jul 22, 2024 · e24192c · e24192c
1 parent 59c6c29
commit e24192c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/mmv1/products/bigquery/Table.yaml b/mmv1/products/bigquery/Table.yaml
@@ -48,6 +48,10 @@ virtual_fields:
     name: 'allow_resource_tags_on_deletion'
     description: |
       If set to true, it allows table deletion when there are still resource tags attached.
+    deprecation_message: |
+      `allow_resource_tags_on_deletion` is deprecated and will be removed in a future major release.
+      The default behavior will be allowing the presence of resource tags on deletion after the next
+      major release.
     default_value: false
 parameters:
   # TODO(alexstephen): Remove once we have support for placing

diff --git a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go
@@ -1254,7 +1254,8 @@ func ResourceBigQueryTable() *schema.Resource {
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
-				Description: `Whether or not to allow table deletion when there are still resource tags attached.`,
+				Description: `**Deprecated** Whether or not to allow table deletion when there are still resource tags attached.`,
+				Deprecated:  `This field is deprecated and will be removed in a future major release. The default behavior will be allowing the presence of resource tags on deletion after the next major release.`,
 			},
 
 			// TableConstraints: [Optional] Defines the primary key and foreign keys.

diff --git a/mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown b/mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown
@@ -184,6 +184,10 @@ The following arguments are supported:
     deletion when there are still resource tags attached. The default value is
     false.
 
+    ~>**Warning:** `allow_resource_tags_on_deletion` is deprecated and will be
+      removed in a future major release. The default behavior will be allowing
+      the presence of resource tags on deletion after the next major release.
+
 <a name="nested_external_data_configuration"></a>The `external_data_configuration` block supports:
 
 * `autodetect` - (Required) - Let BigQuery try to autodetect the schema