Address CRAN feedback

wlandau · Mar 20, 2023 · b0d2af9 · b0d2af9
1 parent 0f915ae
commit b0d2af9
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -4,16 +4,19 @@ Description: In computationally demanding analysis projects,
   statisticians and data scientists asynchronously
   deploy long-running tasks to distributed systems,
   ranging from traditional clusters to cloud services
-  The 'NNG'-powered 'mirai' R package is a sleek
+  The 'NNG'-powered 'mirai' R package by Gao (2023)
+  <https://CRAN.R-project.org/package=mirai> is a sleek
   and sophisticated scheduler that
   efficiently processes these intense workloads.
   The 'crew' package extends 'mirai' with a unifying
   interface for third-party worker launchers.
   Inspiration also comes from packages
-  'future' (2021, <doi:10.32614/RJ-2021-048>), 'rrq',
-  'clustermq' (2019, <doi:10.1093/bioinformatics/btz284>),
-  and 'batchtools' (2017, <doi:10.21105/joss.00135>).
-Version: 0.0.3.9000
+  'future' by Bengtsson (2021) <doi:10.32614/RJ-2021-048>,
+  'rrq' by FitzJohn and Ashton (2023) <https://github.com/mrc-ide/rrq>,
+  'clustermq' by Schubert (2019) <doi:10.1093/bioinformatics/btz284>),
+  and 'batchtools' by Lang, Bischel, and Surmann (2017)
+  <doi:10.21105/joss.00135>.
+Version: 0.0.4
 License: MIT + file LICENSE
 URL: https://wlandau.github.io/crew/, https://github.com/wlandau/crew
 BugReports: https://github.com/wlandau/crew/issues

diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,6 @@
-# crew 0.0.3.9000
-
+# crew 0.0.4
 
+* Adjust references and tests as requested by CRAN.
 
 # crew 0.0.3
 

diff --git a/inst/WORDLIST b/inst/WORDLIST
@@ -89,3 +89,5 @@ CloudWatch
 MERCHANTABILITY
 NONINFRINGEMENT
 Tidyselect
+Bischel
+Surmann
diff --git a/tests/testthat/test-crew_eval.R b/tests/testthat/test-crew_eval.R
@@ -137,6 +137,8 @@ crew_test("crew_eval() environment variables", {
 
 crew_test("crew_eval() options", {
   skip_on_cran()
+  old_options <- options()
+  on.exit(options(old_options)) # Reset to old options on exit.
   expect_null(getOption("crew_option_1"))
   expect_null(getOption("crew_option_2"))
   expect_lt(getOption("warn"), 10)
@@ -161,4 +163,5 @@ crew_test("crew_eval() options", {
       warn = 10L
     )
   )
+  options(old_options) # Reset to old options.
 })