Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For reproducible test result #114

Closed
wants to merge 0 commits into from
Closed

Conversation

shikokuchuo
Copy link
Contributor

Prework

Related GitHub issues and pull requests

Summary

Amends patch for test as per comment: #112 (comment)

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (5cfd904) 100.00% compared to head (54b75e9) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1284      1284           
=========================================
  Hits          1284      1284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wlandau
Copy link
Owner

wlandau commented Sep 5, 2023

Would you see if 0a5ccfe fixes the original testing issue on your end? The goal of the test is to verify that the task used the correct seed, so I'm afraid set.seed() inside the task of the command defeats the purpose.

@shikokuchuo
Copy link
Contributor Author

Hmm seems I automatically closed this when I was trying to pull from your latest branch... but that's fine as your latest commit does indeed fix this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants