Issue57 fix #62
Closed
Issue57 fix #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 4, 2013 23:09
…e classes get loaded before the test runner's setup_databases() is called. When the resource classes are loaded, they create their default querysets, which save off database connections (wrapped in collection objects). Since this happens before setup_databases(), all of these connections will point to settings.MONGO_DATABASE_NAME because of the connect() call in settings.py. Then, before the tests actually start, setup_databases() is called, which opens a new connection to ('test_%s' % settings.MONGO_DATABASE_NAME) under the same alias. At this point all the resource classes have their connections to the original (wrong) database, so unit tests that just access the database through the API work fine. But if unit tests want to access the database directly through the ORM, then a new connection will be created and will point to the new (correct) database. Obviously this will lead to problems because different methods of access "the database" are using different connections to different databases!
The test runner module is loaded after settings.py, but before the test discovery loads all the resources, so adding a connect() call at module load time fixes the issue.
|
Please make another pull request for database issues. |
| connect(DB_NAME, **getattr(settings, 'MONGO_DATABASE_OPTIONS', {})) | ||
|
|
||
|
|
||
| # We need to call this at module load time, because unit test discover will |
There was a problem hiding this comment.
Is this needed? I thought I fixed this with this code? Maybe some Tastypie version broke that? I know that they changed in few versions back how this behave (removed _reset_already_indexed as well). I thought that you don't cache the connection anymore?
We should maybe make a test for that?
|
Please sign-off your pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests and a fix for #57.
I also fixed an issue I ran into with the database connections in the unit tests.