Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunneldigger.init: add support for multiple tunneldigger sections #23

Closed
wants to merge 1 commit into from

Conversation

pmelange
Copy link

@pmelange pmelange commented Oct 9, 2018

The init script was not successfully starting tunneldigger when there
were multiple tunneldigger sections specified in the config file. The
config_cb has been substitued with a handle_td function which is called
with a config_foreach, thereby simplifying the script.

Signed-off-by: pmelange [email protected]

The init script was not successfully starting tunneldigger when there
were multiple tunneldigger sections specified in the config file. The
config_cb has been substitued with a handle_td function which is called
with a config_foreach, thereby simplifying the script.

Signed-off-by: pmelange <[email protected]>
@robimarko
Copy link
Contributor

I gotta test this first, if it works it will be merged

@pmelange
Copy link
Author

pmelange commented Nov 3, 2018

@robimarko I am working on more improvements for freifunk-berlin. Using an init script is not the best solution for us. So I have created a hotplug script. There is now another updated init script which by default is disabled so users can run /etc/init.d/tunneldigger {stop|start|restart}. But as interfaces go up and down, the associated tunnels are started/stopped.

Please take a look at: https://github.com/freifunk-berlin/firmware-packages/tree/freifunk-berlin-tunneldigger/addons/freifunk-berlin-tunneldigger

If this would be helpful to wlanslovenija in any way, I would be happy to see them integrated.

@pmelange
Copy link
Author

pmelange commented Nov 3, 2018

Check out commit freifunk-berlin/firmware-packages@c8a43b2 (and because I forgot to include config.default in the file tree, commit freifunk-berlin/firmware-packages@e88d06b)

@pmelange
Copy link
Author

pmelange commented Nov 4, 2018

OK, I have squashed the commits into three distinct parts and made a PR for freifunk-berlin. You can see the changes at freifunk-berlin/firmware-packages#154 and more specifically freifunk-berlin/firmware-packages@405a582

It is important to note that by default we (freifunk-berlin) disable the init script. We keep the init script for convenience (/etc/init.d/tunneldiggert restart). Otherwise, the hotplug script takes care of everything.

This also solved wlanslovenija/tunneldigger#84 because the hotplug script will not start tunneldigger until the bind_interface goes up.

@pmelange pmelange closed this Aug 19, 2023
@pmelange pmelange deleted the tunneldigger_init branch August 19, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants