fix for AJ-SR04M sensor

[lexxnsk]

When using AJ-SR04M sensor, pulseIn function always returns 0 when timeout value is about 5-10 thousands. I don't know why.
With HC-SR04 behavior is different - it returns real value. So to support both sensors, I've added this additional logic:
unsigned long duration = pulseIn(echoPin, HIGH, 30000);
return (duration > 0 && duration < maxTimeUs);

Summary by CodeRabbit

• Refactor

  • Improved ultrasonic sensor detection for more accurate and reliable measurements.

• Style

  • Applied minor formatting enhancements.

[coderabbitai]

Walkthrough

The pull request modifies the logic of the ultrasoundRead function in the Animated_Staircase module. The update changes how the function checks for a valid ultrasonic pulse by using a fixed timeout of 30,000 microseconds to capture the duration. It now returns true only if the captured duration is greater than zero and less than the provided maximum time. Additionally, a newline was added after the REGISTER_USERMOD(animated_staircase); line.

Changes

File	Change Summary
usermods/.../Animated_Staircase.cpp	Updated ultrasoundRead logic: now captures the pulse duration using a fixed 30,000 µs timeout and returns true if the duration is >0 and <maxTimeUs; added a newline after the REGISTER_USERMOD(animated_staircase); statement.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c1a6d6 and 55c69d0.

📒 Files selected for processing (1)

• usermods/Animated_Staircase/Animated_Staircase.cpp (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• usermods/Animated_Staircase/Animated_Staircase.cpp

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lexxnsk]

#4634

[blazoncek]

Please thoroughly check on all supported sensors.

[blazoncek]

This line is required to drop signal pin LOW and end transmission. Please revert.

[lexxnsk]

you're right.
It was mistakenly deleted

[lexxnsk]

I've reverted this line and committed this fix as well. Please, have a look.

[blazoncek]

Currently I have no way of testing it but I think adding 30ms wait for response may be a bit long and can produce visible hiccups in LED display (default FPS is 42 or about 23ms between frames).

Even though approved I would be cautius with the merge and would require thorough testing before doing so (using both sensors).

[lexxnsk]

I will test it in coming weeks. I will update you with the results within this thread.
Thanks.