Skip to content

Conversation

itCarl
Copy link
Contributor

@itCarl itCarl commented Oct 8, 2025

Hi,
i tried to fix #4829 with this. Hope this helps.
Since the platform_packages shouldn't override the default packages anymore the parameter got removed in commit 5bd0a26 this causes a issue when trying to compile [esp32] builds. So i added empty platform_packages back into the config to resolve this issue.

Summary by CodeRabbit

  • Chores
    • Introduced an empty configuration option for package overrides in the ESP32-S2 and ESP32-C3 build environments.
    • Ensures these environments explicitly support future package specification without altering current behavior.
    • No changes to runtime behavior or features; existing builds and functionality remain unaffected.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Added an empty platform_packages key to the esp32s2 and esp32c3 environments in platformio.ini.

Changes

Cohort / File(s) Summary of Changes
Configuration updates
platformio.ini
Inserted platform_packages entries (empty) under [esp32s2] and [esp32c3] sections.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title directly references the specific error message being addressed and clearly communicates that the pull request resolves the missing ‘platform_packages’ option in the esp32s2 section, making it concise and focused on the primary change.
Linked Issues Check ✅ Passed The pull request adds the missing ‘platform_packages’ entries to the esp32s2 and esp32c3 build sections in platformio.ini, directly preventing the InvalidProjectConfError described in issue #4829 by ensuring that the expected configuration key exists.
Out of Scope Changes Check ✅ Passed All modifications in this pull request pertain to adding missing configuration keys for platform_packages in the specified build environments, and there are no unrelated or extraneous changes outside of that scope.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eku
Copy link

eku commented Oct 9, 2025

Nice try, but this does not solve the builds that require these values to be non empty.

@itCarl
Copy link
Contributor Author

itCarl commented Oct 9, 2025

Nice try, but this does not solve the builds that require these values to be non empty.

Have a look at the esp32 section. There is also a empty platform_packages parameter. So guess it does not have to be filled.

Can u tell me what builds need the platform_packages? I might have a look at them.

@itCarl
Copy link
Contributor Author

itCarl commented Oct 9, 2025

It seems that platform_packages were already present a while ago.
Got first added here:
image
then it changed couple of times over the years.

and here it got removed:
image

I also think a guy alredy tried to fix this config issue but his pr got rejected. #4830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidProjectConfError: Invalid 'wled/src/platformio.ini' (project configuration file): 'No option 'platform_packages' in section: 'esp32s2''

2 participants