-
-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor and relocate JSON logger tests for Go 1.21 compliance
Removed JSON logger tests from smtp_test.go and relocated them to a new file smtp_121_test.go, ensuring compliance with Go 1.21. This change maintains test integrity while organizing tests by Go version compatibility.
- Loading branch information
Showing
2 changed files
with
59 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// SPDX-FileCopyrightText: Copyright 2010 The Go Authors. All rights reserved. | ||
// SPDX-FileCopyrightText: Copyright (c) 2022-2023 The go-mail Authors | ||
// | ||
// Original net/smtp code from the Go stdlib by the Go Authors. | ||
// Use of this source code is governed by a BSD-style | ||
// LICENSE file that can be found in this directory. | ||
// | ||
// go-mail specific modifications by the go-mail Authors. | ||
// Licensed under the MIT License. | ||
// See [PROJECT ROOT]/LICENSES directory for more information. | ||
// | ||
// SPDX-License-Identifier: BSD-3-Clause AND MIT | ||
|
||
//go:build go1.21 | ||
// +build go1.21 | ||
|
||
package smtp | ||
|
||
import ( | ||
"fmt" | ||
"os" | ||
"strings" | ||
"testing" | ||
|
||
"github.com/wneessen/go-mail/log" | ||
) | ||
|
||
func TestClient_SetDebugLog_JSON(t *testing.T) { | ||
t.Run("set debug loggging to on should not override logger", func(t *testing.T) { | ||
client := &Client{logger: log.NewJSON(os.Stderr, log.LevelDebug)} | ||
client.SetDebugLog(true) | ||
if !client.debug { | ||
t.Fatalf("expected debug log to be true") | ||
} | ||
if client.logger == nil { | ||
t.Fatalf("expected logger to be defined") | ||
} | ||
if !strings.EqualFold(fmt.Sprintf("%T", client.logger), "*log.JSONlog") { | ||
t.Errorf("expected logger to be of type *log.JSONlog, got: %T", client.logger) | ||
} | ||
}) | ||
} | ||
|
||
func TestClient_SetLogger_JSON(t *testing.T) { | ||
t.Run("set logger to JSONlog logger", func(t *testing.T) { | ||
client := &Client{} | ||
client.SetLogger(log.NewJSON(os.Stderr, log.LevelDebug)) | ||
if !strings.EqualFold(fmt.Sprintf("%T", client.logger), "*log.JSONlog") { | ||
t.Errorf("expected logger to be of type *log.JSONlog, got: %T", client.logger) | ||
} | ||
}) | ||
t.Run("nil logger should just return and not set/override", func(t *testing.T) { | ||
client := &Client{logger: log.NewJSON(os.Stderr, log.LevelDebug)} | ||
client.SetLogger(nil) | ||
if !strings.EqualFold(fmt.Sprintf("%T", client.logger), "*log.JSONlog") { | ||
t.Errorf("expected logger to be of type *log.JSONlog, got: %T", client.logger) | ||
} | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters