Feature(sendError): add unwrap interface #356
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a brief description of my problem:
I'm trying to validate if a FROM address is valid, and I'm looking into the SMTP Error codes.
I noticed that you receive the error codes, and hide then behind the SendError struct.
It would be helpful for me to have a direct access to these error codes through textproto.Error, instead of parsing them from the error message.
We Have the errors.As function, that tries to go error to error from the error stack, until the type assertion Matches.
I'm implementing the Unwrap interface on SendError for that reason, so we can do errors.As and extract any internal error from the SendError struct.
Another possible solution would be if you also stored the ErrorCode on the SendError struct.