Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor header count logic for accurate line tracking #421

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

wneessen
Copy link
Owner

Changed headerCount from uint to int and updated its logic to accurately count lines written in headers. Modified writeHeader to return the number of lines written, ensuring better alignment between header tracking and actual output. This fixes a bug with S/MIME signing if a header line spanned over more than one line.

Changed `headerCount` from `uint` to `int` and updated its logic to accurately count lines written in headers. Modified `writeHeader` to return the number of lines written, ensuring better alignment between header tracking and actual output. This fixes a bug with S/MIME signing if a header line spanned over more than one line.
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (559046e) to head (077c438).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files          30       30           
  Lines        3532     3534    +2     
=======================================
+ Hits         3345     3347    +2     
  Misses        138      138           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen wneessen merged commit f781a50 into main Jan 13, 2025
29 checks passed
@wneessen wneessen deleted the bug/smime-fix-header-count branch January 13, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant