Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove release please & bump versions #347

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

matheus23
Copy link
Member

I want to move away from release-please because:

  • It continues trying to release wnfs-bench, even though it shouldn't. (We've tried removing wnfs-bench from all configuration JSONs, but release-please just adds it back, presumably because it reads it from the history somewhere)
  • It doesn't handle new crates in the workspace well at all. (Between removing wnfs-namefilter and adding wnfs-nameaccumulator it just got totally confused and we had to manually publish the second release of wnfs-nameaccumulator. This also caused all other crates to not release properly, since they depend on wnfs-nameaccumulator...)
  • Now that we've done one manual release, it's gotten completely confused. (See chore: release main #344 and the CHANGELOGs it generated)
  • While putting together this PR, I realized that the CHANGELOG formatting got messed up at some point for the wnfs-hamt crate.

So this PR simply removes the workflow.
I also bumped the versions in preparation for a release & added CHANGELOGs.

@matheus23 matheus23 requested a review from a team as a code owner September 4, 2023 12:49
@matheus23 matheus23 self-assigned this Sep 4, 2023
@appcypher
Copy link
Member

More trouble than it is worth. 😮‍💨
So back to manual releases or is there a plan to find a replacement?

@matheus23
Copy link
Member Author

Yep. Back to manual :/

@matheus23 matheus23 force-pushed the matheus23/remove-release-please-and-bump branch from b3d89d9 to 0219598 Compare September 10, 2023 15:19
@matheus23 matheus23 merged commit 6111cf2 into main Sep 10, 2023
@matheus23 matheus23 deleted the matheus23/remove-release-please-and-bump branch September 10, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants