fix: Public reconciliation of a concurrent write and remove (of independent paths) #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an edge case I came across while implementing private conflict reconciliation.
Essentially we have this setup:
What happened previously was:
b.txt
file gets re-introduced (the remove gets "overwritten"), because we don't re-check the causal relationship of the "a" directories.We now check the causal relationship between directories on every level (recursively).
I also removed the
merge
function, as otherwise it'd be hard to disentangle the recursion, but that'd be needed to not duplicate the wholereconcile_helper
andmerge_helper
functions.