Solution refactoring (according to comment to pull request) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed unnecessary if-checks 2. Simplified restEpoch computation 3. Replaced forEach with flatMap 4. DailyUsage made less anemic, has now isMultiDaySession method In the next step i would move the whole generateSessionDays() logic to DailyUsage. Dislaimer: There may be issues, I haven't checked the code to long. Known issues: 1. getMidnightOfDate duplication 2. (int) wholeDaysCount -> overflow risk If you found more issues, please give a feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next step i would move the whole generateSessionDays() logic to DailyUsage.
Dislaimer: There may be issues, I haven't checked the code to long. I was focused only on the logic, I haven't refactored names, etc.
Known issues:
If you found more issues, please give a feedback.