-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial #1
Initial #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great. I have done an initial review and answered some questions. I will look in more detail later.
lib/nimble_hex/repository.ex
Outdated
defmodule NimbleHex.Repository do | ||
@moduledoc false | ||
|
||
@derive {Inspect, only: [:name, :public_key, :store, :registry]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@ericmj updated! I've moved docs around, now the README has an overview of features and step-by-step guide of using it with Hex and Rebar3 (todo). I've moved more comprehensive docs to module docs (which are linked to at the end of the README) I've also added a more realistic mirror implementation that calculates the diff and only downloads what's required. It also has the same mechanism of loading/saving registry backup as the regular repos. The mirror implementation currently doesn't handle when someone overwrites a given release, I'll add an issue for it later. WDYT? |
README.md
Outdated
|
||
We welcome anyone to contribute to the project, especially around documentation and guides, | ||
but features specific to narrow set of users likely won't be accepted. For a complete and | ||
production-grade implementation see source code of [Hex.pm](https://github.com/hexpm/hexpm). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clarify further that hexpm is not for running your organization's Hex server, rather it's for running Hex.pm specifically which has very different constraints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call. How about:
For a complete and
production-grade implementation see source code of Hex.pm, however keep in mind it's optimised for running the public registry for the community and thus have different features and constraints than a self-hosted solution might have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I've merged it so that people can easily start testing it, but feedback on the PR is still welcome of course! |
No description provided.