Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial #1

Merged
merged 10 commits into from
Jul 22, 2019
Merged

Initial #1

merged 10 commits into from
Jul 22, 2019

Conversation

wojtekmach
Copy link
Owner

No description provided.

config/config.exs Outdated Show resolved Hide resolved
lib/nimble_hex/mirror/server.ex Outdated Show resolved Hide resolved
lib/nimble_hex/mirror/server.ex Outdated Show resolved Hide resolved
lib/nimble_hex/router.ex Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@wojtekmach
Copy link
Owner Author

cc @ericmj @supersimple @josevalim

README.md Show resolved Hide resolved
Copy link
Collaborator

@ericmj ericmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great. I have done an initial review and answered some questions. I will look in more detail later.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config/config.exs Show resolved Hide resolved
lib/nimble_hex/mirror/server.ex Outdated Show resolved Hide resolved
defmodule NimbleHex.Repository do
@moduledoc false

@derive {Inspect, only: [:name, :public_key, :store, :registry]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wojtekmach
Copy link
Owner Author

@ericmj updated! I've moved docs around, now the README has an overview of features and step-by-step guide of using it with Hex and Rebar3 (todo). I've moved more comprehensive docs to module docs (which are linked to at the end of the README)

I've also added a more realistic mirror implementation that calculates the diff and only downloads what's required. It also has the same mechanism of loading/saving registry backup as the regular repos. The mirror implementation currently doesn't handle when someone overwrites a given release, I'll add an issue for it later.

WDYT?

README.md Outdated

We welcome anyone to contribute to the project, especially around documentation and guides,
but features specific to narrow set of users likely won't be accepted. For a complete and
production-grade implementation see source code of [Hex.pm](https://github.com/hexpm/hexpm).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify further that hexpm is not for running your organization's Hex server, rather it's for running Hex.pm specifically which has very different constraints?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. How about:

For a complete and
production-grade implementation see source code of Hex.pm, however keep in mind it's optimised for running the public registry for the community and thus have different features and constraints than a self-hosted solution might have.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@wojtekmach wojtekmach merged commit 8469495 into master Jul 22, 2019
@wojtekmach wojtekmach deleted the wm-initial branch July 22, 2019 11:25
@wojtekmach
Copy link
Owner Author

I've merged it so that people can easily start testing it, but feedback on the PR is still welcome of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants