JCE: prepend zero byte to DH shared secret if less than prime length #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts wolfJCE's
KeyAgreement
implementation for generating DH shared secrets.Native wolfCrypt generates and returns DH shared secrets that have any zero bytes stripped off. This follows RFC 5246 (8.1.2) which instructs to do so. Other Java KeyAgreement implementations (SunJCE, Bouncy Castle) for DH follow RFC 2631 (2.1.2) which prepends zero bytes if the total secret size is less than the prime length.
This PR adjusts our wolfJCE implementation to match other existing Java implementations, for interop compatibility.
This fixes a sporadic JUnit failure which looks similar to this: