-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DTLS 1.3 (DTLSv1.3
) through SSLContext
/ SSLEngine
#254
Open
cconlon
wants to merge
10
commits into
wolfSSL:master
Choose a base branch
from
cconlon:dtls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13288e4
to
61fa093
Compare
… System property jdk.tls.useExtendedMasterSecret
…ng WolfSSLEngine handshakeFinished to true
…kie(), enable HelloRetryRequest in SSLEngine DTLS
… DTLS dropped packet detection for BUFFER_UNDERFLOW status
6399a7b
to
5f10363
Compare
…lback to SSLEngine for detection of ticket received
… error state is not fatal
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DTLS 1.3 support to the wolfJSSE
SSLContext
class, for use through theSSLEngine
interface. SunJSSE supports up to DTLS 1.2 through the SSLEngine interface, so we are matching similar behavior here for DTLS 1.3.To support this addition, this PR also makes the following changes:
wolfSSL_DisableExtendedMasterSecret()
jdk.tls.useExtendedMasterSecret
for enabling or disabling the TLS Extended Master Secret (EMS) extension. Enabled by default unless explicitly disabled.wolfSSL_send_hrr_cookie()
inWolfSSLSession.sendHrrCookie()
for enabling HelloRetryRequest use in SSLEngine DTLS support.wolfSSL_dtls_get_drop_stats()
for use in SSLEngine DTLS detection of dropped packets to properly setBUFFER_UNDERFLOW
status.wolfSSL_set_SessionTicket_cb()
and add session ticket callback support to SSLEngine for detection of ticket being received.wolfSSL Configuration
When testing this work, wolfSSL was configured using:
Native wolfSSL's build option for
--enable-jni
will be updated to include these definitions by default, with wolfSSL/wolfssl#8481.Testing
Simple JUnit tests for SSLEngine DTLSv1.3 have been added with this PR. This has also been tested against modified versions of the SunJSSE DTLS tests, specifically:
A PR to the testing repo has been opened here: https://github.com/wolfSSL/testing/pull/844. A nightly Jenkins test will be created based on the test script in that PR.
Examples
JNI-level example client and server can be run with DTLS 1.3 support using:
Future Work
SSLContext('DTLS')
general mappingSSLContext('DTLSv1.2')
for DTLS 1.2 support