Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom errors #52

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Custom errors #52

merged 11 commits into from
Jan 17, 2024

Conversation

wolfadex
Copy link
Owner

No description provided.

Copy link
Collaborator

@miniBill miniBill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick notes

src/CliMonad.elm Outdated Show resolved Hide resolved
src/OpenApi/Generate.elm Outdated Show resolved Hide resolved
src/OpenApi/Generate.elm Outdated Show resolved Hide resolved
src/OpenApi/Generate.elm Outdated Show resolved Hide resolved
Comment on lines +1486 to +1484
-- NOTE: The below results in unexpected codegen like:
--
-- Http.BadUrl_ string.String ->
-- Result.Err (BadUrl string.String)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fixed in the last elm-codegen

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so as well, but I'm stuck on an old version because elm-pages depends on an old version :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's so how the CI feels about bumping the dependency 😄 dillonkearns/elm-pages#434

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Cypress has been acting up on my builds lately 😢 I think it's working though because there are >0 passing cypress tests, which means it's running.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and merged. I'll sort out the cypress CI issues and do a deploy soon.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub was having issues recently, not sure if it'd impact your CI at all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been happening intermittently for a while, so probably unrelated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all good here now with the latest release, by the way!

@wolfadex wolfadex merged commit 8d867c9 into main Jan 17, 2024
1 check passed
@miniBill miniBill deleted the wolfadex/custom-errors branch July 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants