Remove elm-community/json-extra as a dependency of the generated code #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfadex
commented
Apr 14, 2024
| @@ -1878,6 +1878,39 @@ typeToDecoder type_ = | |||
| CliMonad.todo "Bytes decoder not implemented yet" | |||
|
|
|||
|
|
|||
| jsonDecodeAndMap : Elm.Declaration | |||
| jsonDecodeAndMap = | |||
There was a problem hiding this comment.
I tried using Elm.Declaration.fn2 but the type annotation kept being generated as
Json.Decode.Decoder a -> Json.Decode.Decoder (a -> b) -> Json.Decode.Decoder valuewhen I used Elm.val "(|>)", and when I tried used an anonymous function instead running the codegen would hang indefinitely.
This felt like a fine compromise
There was a problem hiding this comment.
It's fine. Eventually we'll have @Janiczek's type inference and all these bugs will be lost in time, like tears in rain...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #63
Also updates some dependencies