-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jupyter-base-notebook): add jupyterhub py package dep #41195
base: main
Are you sure you want to change the base?
feat(jupyter-base-notebook): add jupyterhub py package dep #41195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small comment around string in expected_output and we can also cleanup pip install jupyterlab
as part of this patch.
Because the jupyter-base-notebook package resembles the upstream jupyter/base-notebook component, it should include the jupyterhub python package. In particular, upstream includes the jupyterhub-singleuser conda metapackage that aligns to the jupyterhub pypi package. Signed-off-by: Massimiliano Giovagnoli <[email protected]>
10f5ff2
to
681df3c
Compare
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: • Detected Error: • Suggested Fix:
pipeline:
- runs: |
export PATH="/usr/bin:$PATH"
mkdir -p ${{targets.contextdir}}/usr/local/bin
mkdir -p ${{targets.contextdir}}/home/jovyan/.jupyter
# install jupyterlab, nbclassic and notebook
pip install jupyterhub --prefix=/usr --root=${{targets.contextdir}}
pip install jupyterlab --prefix=/usr --root=${{targets.contextdir}}
pip install nbclassic --prefix=/usr --root=${{targets.contextdir}}
pip install notebook --prefix=/usr --root=${{targets.contextdir}}
export PYTHONPATH="${{targets.contextdir}}/usr/lib/python3.12/site-packages:$PYTHONPATH"
jupyter server --generate-config
cp /home/build/.jupyter/jupyter_server_config.py ${{targets.contextdir}}/home/jovyan/.jupyter/jupyter_server_config.py
jupyter lab clean • Explanation:
• Additional Notes:
• References: |
Because the jupyter-base-notebook package resembles the upstream jupyter/base-notebook component, it should include the jupyterhub python package. In particular, upstream includes the jupyterhub-singleuser conda metapackage that aligns to the jupyterhub pypi package.
Fixes:
Related:
Pre-review Checklist
For new package PRs only
endoflife.date
)For new version streams
name: ${{package.name}}-compat
)provides:
logical unversioned forms of the package (e.g.nodejs
,nodejs-lts
)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latest
successfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epoch
field is reset to 0For PRs that add patches