Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-collector/0.119.0 package update #41222

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Feb 4, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Feb 4, 2025
Copy link
Contributor Author

octo-sts bot commented Feb 4, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: No specific error message is shown, but the build appears to stop at the "Compiling" step

• Error Category: Build/Configuration

• Failure Point: The compilation step using the OpenTelemetry Collector Builder (ocb)

• Root Cause Analysis:
The build is failing during compilation, likely due to incomplete or incorrect module replacement directives. The current replacements only handle crypto and net modules, but may be missing other required replacements.

• Suggested Fix:
Add additional module replacements that are commonly needed for OpenTelemetry builds:

  - runs: |
      set -x
      # Use the builder to compile opentelemetry-collector
      yq eval '.replaces += ["golang.org/x/crypto => golang.org/x/crypto v0.31.0"]' builder-config.yaml -i
      yq eval '.replaces += ["golang.org/x/net => golang.org/x/net v0.33.0"]' builder-config.yaml -i
      yq eval '.replaces += ["golang.org/x/sys => golang.org/x/sys v0.13.0"]' builder-config.yaml -i
      yq eval '.replaces += ["golang.org/x/text => golang.org/x/text v0.13.0"]' builder-config.yaml -i
      ${{targets.destdir}}/usr/bin/ocb --config=builder-config.yaml

• Explanation:
OpenTelemetry often requires consistent versions of core Go modules. Adding these replacements ensures all golang.org/x/* dependencies are at compatible versions, preventing potential version conflicts during compilation.

• Additional Notes:

  • Consider adding CGO_ENABLED=0 for static builds
  • You may want to add GO111MODULE=on to ensure module mode
  • The builder may need more memory; consider setting GOMAXPROCS if the build fails again

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Feb 4, 2025
@OddBloke OddBloke self-assigned this Feb 4, 2025
@OddBloke OddBloke force-pushed the wolfictl-8a5e0915-7deb-47c6-ae7b-cd2cc7b539d6 branch from 10a625d to 037a7d6 Compare February 4, 2025 15:30
@OddBloke
Copy link
Member

OddBloke commented Feb 4, 2025

Blocked until open-telemetry/opentelemetry-collector-releases#811 lands with the build configuration we rely upon.

wolfi-bot and others added 2 commits February 5, 2025 08:24
Previously we would build with a configuration file containing "404 Not
Found" (which was, surprisingly, mostly successful).
@OddBloke OddBloke force-pushed the wolfictl-8a5e0915-7deb-47c6-ae7b-cd2cc7b539d6 branch from 037a7d6 to 138bef9 Compare February 5, 2025 13:24
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Feb 5, 2025
@OddBloke OddBloke requested a review from a team February 5, 2025 13:29
@OddBloke OddBloke enabled auto-merge February 5, 2025 13:29
@OddBloke OddBloke merged commit 3992bc7 into main Feb 5, 2025
15 checks passed
@OddBloke OddBloke deleted the wolfictl-8a5e0915-7deb-47c6-ae7b-cd2cc7b539d6 branch February 5, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants