Add note about stimulus-blurhash #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thisen
requested changes
Feb 7, 2023
| @@ -11,7 +11,7 @@ | |||
| npm install --save blurhash | |||
| ``` | |||
|
|
|||
| See [react-blurhash](https://github.com/woltapp/react-blurhash) to use blurhash with React. | |||
| See [react-blurhash](https://github.com/woltapp/react-blurhash) to use blurhash with React or [stimulus-blurhash](https://github.com/bb/stimulus-blurhash) to use it with Hotwire Stimulus. | |||
There was a problem hiding this comment.
I think this implementation should be listed under implementations in README!
There was a problem hiding this comment.
I can of course add both react-blurhash and stimulus-blurhash to the global README. However, neither of those are actual implementations. They both have the TypeScript implementation as a dependency. So I'd add both react-blurhash and stimulus-blurhash as sub-bullets of the TypeScript implementation? Or would you prefer somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I admit it's self-promo, but still useful.
Also, compared to the react-version it uses background-image with data URL instead of adding a canvas element to the DOM.