Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coffee Maker Example App] Simulate polling for fetching coffee orders #309

Merged

Conversation

ulusoyca
Copy link
Collaborator

Description

This PR prepares the coffee maker navigator 2.0 demo app for the workshop which will be held in Flutter&Friends.

Changes:

  • Simulate polling with 3 seconds interval for the fetching of the coffee orders.

Copy link

It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment.

@ulusoyca
Copy link
Collaborator Author

It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment.

@TahaTesser Cool stuff!

@ulusoyca ulusoyca force-pushed the coffee-maker-demo-app-mock-polling-for-fetching-orders branch from 179c990 to 68abeaf Compare August 19, 2024 20:29
Copy link

It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment.

@ulusoyca ulusoyca merged commit 9d88159 into main Aug 19, 2024
4 checks passed
@ulusoyca ulusoyca deleted the coffee-maker-demo-app-mock-polling-for-fetching-orders branch August 19, 2024 20:31
@TahaTesser
Copy link
Collaborator

I'll probably remove synchronised condition so it doesn't repeat the comment when pushing new commits or rebasing the PR. Only comment when PR is opened or reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants