Async shell calls #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should really pull this.. It made wakatime-mode go from an unusable state of interrupting me by freezing emacs from time to time my work to very usable. |
|
+1 |
Async shell calls
Don't warn about existing processes + Don't start process unless file buffer
…n't warn about response code 102, because that just means we are working offline.
…init function once.
to allow logging of paths containing spaces
Add quoting to file argument in client command
…dy checked the PATH for python
Add package footer for packaging convention
Update MELPA URL
* Support pyenv wakatime * Support Homebrew wakatime-cli
Guess wakatime-cli-path if it's not set.
The code doesn’t use it anywhere yet.
Now if the API key is not set, this tries to run wakatime anyway (hoping the API key is present in the user’s config file). If wakatime exits with 102 (ie. invalid API key), it asks for an API key and reruns the command. This is an attempt to solve #18.
Attempt to run without an API key
Add validity checker for API keys
This is required to preserve variable values for `savep` and `retrying`.
It tried not to use the API key when it was actually required.
Fix API key request and a problem with running without an API key
The closure from the original solution wasn’t really helping. The required function parameters are now referenced by value.
…ime installed via pip
Correctly match cli.py in wakatime-cli-path
|
This is the old repo location that's no longer maintained. Can you submit this PR to https://github.com/wakatime/wakatime-mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #9