Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add active source to Help drawer #1219

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Add active source to Help drawer #1219

merged 3 commits into from
Dec 9, 2024

Conversation

crstauf
Copy link
Contributor

@crstauf crstauf commented Dec 6, 2024 •
edited by barryhughes
Loading

Closes #772.
See #1218.

Changelog

Add - Additional information about the active instance of Action Scheduler is now available in the Help pull-down drawer.

@crstauf
Copy link
Contributor Author

crstauf commented Dec 6, 2024 •
edited
Loading

At present, this only displays the path to the active AS library. Showing the plugin's or theme's name is a WIP.

2024-12-06T194740

@barryhughes barryhughes self-requested a review December 6, 2024 21:01
@barryhughes
Copy link
Member

Thanks! I left a couple of (minor) suggestions, but this otherwise looks good 👍🏼

crstauf and others added 2 commits December 9, 2024 13:40
@crstauf @barryhughes
improve help language
691762f 
Co-authored-by: Barry Hughes <[email protected]>
@crstauf @barryhughes
escape output
9d0ff8d 
Co-authored-by: Barry Hughes <[email protected]>
@crstauf crstauf requested a review from barryhughes December 9, 2024 18:41
@barryhughes barryhughes merged commit 4326df7 into woocommerce:trunk Dec 9, 2024
34 checks passed
@barryhughes barryhughes added this to the 3.9.1 milestone Dec 9, 2024
@crstauf crstauf deleted the fix-772 branch December 9, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryhughes barryhughes barryhughes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

Add parent plugin details to Help pulldown
2 participants
@crstauf @barryhughes