2535: Consolidate Ad Creation

[asvinb]

Changes proposed in this Pull Request:

Closes #2535 .

Replace this with a good description of your changes & reasoning.

Detailed test instructions:

1. Go through the onboarding process and ensure a paid campaign can be created.
   • When billing is not set up, the "Launch Paid Campaign" button should be disabled.
2. Ensure the skip paid ads modal is displayed when the user clicks the skip button during the onboarding flow.
3. Go through the setup ads flow (/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-ads) and ensure a paid campaign can be created if billing is setup.
4. Ensure a paid campaign can be added via the "Add a paid campaign" button on the dashboard.
5. Ensure a paid campaign can be edited via the "Edit" links on the dashboard.
   • The budget recommendation should be for the selected countries for the paid campaign.
6. Test when billing is not setup flow, ie. the user is prompted to setup billing.
7. Users should not be able to submit/continue any flow if billing is not set up and approved.
8. Users are no longer able to view the targeted countries.

Extra issues to test:

• 2535: Consolidate Ad Creation #2623 (comment)
• 2535: Consolidate Ad Creation #2623 (comment)

Additional details:

Changelog entry

Update - Consolidate the campaign setup UI in the onboarding flow with the one in the ads setup flow.

[codecov]

Codecov Report

Attention: Patch coverage is 16.12903% with 26 lines in your changes missing coverage. Please review.

Project coverage is 62.1%. Comparing base (95d6452) to head (52ba585).
Report is 65 commits behind head on feature/2459-campaign-creation-flow.

Files with missing lines	Patch %	Lines
...c/components/paid-ads/ads-campaign/ads-campaign.js	0.0%	14 Missing and 3 partials ⚠️
js/src/pages/create-paid-ads-campaign/index.js	0.0%	3 Missing and 1 partial ⚠️
js/src/setup-ads/ads-stepper/setup-paid-ads.js	57.1%	3 Missing ⚠️
...src/components/paid-ads/asset-group/asset-group.js	0.0%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                          Coverage Diff                          @@
##           feature/2459-campaign-creation-flow   #2623     +/-   ##
=====================================================================
+ Coverage                                 61.8%   62.1%   +0.3%     
=====================================================================
  Files                                      327     327             
  Lines                                     5108    5109      +1     
  Branches                                  1242    1244      +2     
=====================================================================
+ Hits                                      3157    3171     +14     
+ Misses                                    1771    1756     -15     
- Partials                                   180     182      +2     

Flag	Coverage Δ
js-unit-tests	62.1% <16.1%> (+0.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...src/components/paid-ads/ads-campaign/faqs-panel.js	66.7% <ø> (ø)
...paid-ads/ads-campaign/paid-ads-features-section.js	0.0% <ø> (ø)
js/src/pages/edit-paid-ads-campaign/index.js	9.3% <ø> (ø)
js/src/setup-ads/ads-stepper/index.js	100.0% <100.0%> (ø)
...src/components/paid-ads/asset-group/asset-group.js	4.4% <0.0%> (-0.2%)	⬇️
js/src/setup-ads/ads-stepper/setup-paid-ads.js	57.1% <57.1%> (ø)
js/src/pages/create-paid-ads-campaign/index.js	10.3% <0.0%> (ø)
...c/components/paid-ads/ads-campaign/ads-campaign.js	0.0% <0.0%> (ø)

... and 5 files with indirect coverage changes

[ankitguptaindia]

✅ Verified the changes from a user perspective and confirmed that creating, editing, and managing paid ad campaigns from all desired screens is working without any errors.

✅ When billing is not set up, the merchant is unable to complete the setup process, as expected.

✅ All cases defined in Acceptance Criteria works as expected.

[asvinb]

@ankitguptaindia Can you kindly test the changes please? I also added items to double check in the QAB.

Extra issues to test:

#2623 (comment)
#2623 (comment)

[ankitguptaindia]

QA/Test Report- ✅

Testing Environment -

• WordPress: 6.6.2
• Theme active on store: Twenty Twenty-Four Version: 1.2
• WooCommerce - Version 9.3.3
• PHP: 8.3
• Web Server: Nginx
• Browser: Chrome - Version 129
• OS: macOS Sonoma 14.6.1

Test Results - Tested the use cases described here #2623 (comment) and paid ad creation flow after the recent changes. New paid ad campaign and editing ad campaign flow and other related use cases are working fine now.

Functional Demo / Screencast -

Recording.905.mp4

[eason9487]

Other issues:

• After submitting to create or edit a campaign, an uncaught error occurs.
  
• The CampaignFormValues type no longer has the countryCodes property.
  

  google-listings-and-ads/js/src/components/types.js

  Lines 6 to 7 in d7f0d51

  	* @typedef {Object} CampaignFormValues
  	* @property {Array<CountryCode>} countryCodes Selected country codes for the paid ads campaign.

[asvinb]

@eason9487 The uncaught error has been fixed. Can you kindly check again please?
Thanks!

[eason9487]

Thanks for the work. LGTM.