Remove redundant Pinterest API error handlers

[message-dimke]

Changes proposed in this Pull Request:

Removing the Action Scheduler (AS) action failure hook to disconnect the extension on the Pinterest API call failures from inside the AS actions.

Customers complain about this issue when saying that after a while of the successful connection, the extension gets disconnected.

This is a requested feature that did not work out. Users prefer to stay connected even if the application is not partially working.

Detailed test instructions:

1. Download the extension and connect to your Pinterest account.
2. Edit the code lines below by adding a filter to emulate the request failure

pinterest-for-woocommerce/src/API/APIV5.php

Lines 524 to 530 in 1552a0f

	public static function create_feed( array $data, string $ad_account_id ): array {
	return self::make_request(
	"catalogs/feeds?ad_account_id={$ad_account_id}",
	'POST',
	$data
	);
	}

add exactly before the return statement:

add_filter(
	'pre_http_request',
	function ( $response, $parsed_args, $url ) use ( $ad_account_id ) {
		if ( "https://api.pinterest.com/v5/catalogs/feeds?ad_account_id={$ad_account_id}" === $url ) {
			return array(
				'headers'  => array(
					'content-type' => 'application/json',
				),
				'body'     => json_encode(
					array(
						'code'    => 2625,
						'message' => 'Sorry, you cannot perform this action as your account has been disapproved. Please see business hub for more details. https://www.pinterest.com/business/hub/',
					)
				),
				'response' => array(
					'code'    => 403,
					'message' => 'Forbidden',
				),
				'cookies'  => array(),
				'filename' => '',
			);
		}
	},
	10,
	3
);

3. Go to WooCommerce - Status - Scheduler Actions - Pending

4. Force run the pinterest-for-woocommerce-handle-feed-registration action.
5. Observe that the extension stayed connected and did not reset back to the onboarding flow.

Changelog entry

Update - Do not disconnect on the Action Scheduler action failure.

[rawdreeg]

Thanks @message-dimke. The changes test well. The interest connection is not removed on failed pinterest-for-woocommerce-handle-feed-registration action.