Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACK] Update a plugin from the app #13246

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Open

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 6, 2025

Description

The PR adds opportunity to open the plugins web page from the native plugins list and update the plugins which are outdated

I slightly changed the UI to make it more visible that there is an action

Testing information

  • More -> Settings -> Plugins
  • Click on a outdated plugin
  • Notice that it can be updated via wp-admin now

The tests that have been performed

above

Images/gif

01-06--16-40.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added category: woo extensions Related to WC extensions or plugins. type: enhancement A request for an enhancement. and removed category: woo extensions Related to WC extensions or plugins. labels Jan 6, 2025
@kidinov kidinov added this to the 21.5 milestone Jan 6, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit069f300
Direct Downloadwoocommerce-wear-prototype-build-pr13246-069f300.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit069f300
Direct Downloadwoocommerce-prototype-build-pr13246-069f300.apk

@kidinov kidinov requested a review from AnirudhBhat January 6, 2025 16:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.69%. Comparing base (a816f76) to head (069f300).
Report is 13 commits behind head on trunk.

Files with missing lines Patch % Lines
...merce/android/ui/prefs/plugins/PluginsViewModel.kt 94.73% 1 Missing ⚠️
...merce/android/ui/prefs/plugins/PluginsViewState.kt 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13246      +/-   ##
============================================
+ Coverage     40.59%   40.69%   +0.09%     
- Complexity     6388     6401      +13     
============================================
  Files          1351     1353       +2     
  Lines         77645    77655      +10     
  Branches      10679    10682       +3     
============================================
+ Hits          31517    31598      +81     
+ Misses        43345    43261      -84     
- Partials       2783     2796      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A request for an enhancement. unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants