This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add FormStep to Storybook
#11489
Merged
Add FormStep to Storybook
#11489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
tools
woocommercebot
requested review from
a team and
senadir
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
packages/components/form-step/stories/index.stories.tsx
|
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Nov 2, 2023
opr
force-pushed
the
add/form-step-story
branch
from
72d3454 to
1e77c55
Compare
|
@senadir and @tarunvijwani thanks for reviewing - I have rebased this to work with Storybook 7. I renamed the title of the story so it goes into the |
|
Moving to 11.6.0 |
senadir
approved these changes
Nov 6, 2023
|
@senadir thanks, removed the control for the chidren prop and made all components appear as |
opr
force-pushed
the
add/form-step-story
branch
from
9625263 to
a668b14
Compare
opr
force-pushed
the
add/form-step-story
branch
from
a668b14 to
79760e2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a storybook entry for the
FormStepcomponent we recently exported.Why
To showcase the component and provide a level of documentation.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
npm run storybooklocalhost:6006and check theWooCommerce Blocks/@woocommerce-blocks-components/FormStepcomponent.stepHeadingContentis a React Node so can't be changed in Storybook.)Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog