This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Store Customization] Update product slug when updating the title and flush cache #11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
albarin
added
type: enhancement
albarin
changed the title
albarin
changed the title
albarin
added
the
skip-changelog
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
albarin
requested review from
gigitux and
nefeline
and removed request for
dinhtungdu
nefeline
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Works like a charm 🎉
Confirmed that:
Make sure six new dummy products are created for your store.
All dummy products are created when none is available.
Make sure the generated products have an AI-generated title and a matching slug in their URLs
Confirmed both titles and slugs are updated:
nefeline
reviewed
Nov 28, 2023
| ), | ||
| ) | ||
| ); | ||
| flush_rewrite_rules(); |
There was a problem hiding this comment.
@albarin, my apologies, as this just occurred to me after the PR was merged: could we change here to ensure the rewrite rules are flushed only after all dummy products were created? Flushing the rewrite rules every time a new product is created is very expensive.
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the product slug when updating the dummy product titles and flushes the permalinks cache after it.
Why
Before doing this we ended up with a product with AI-generated titles but the permalinks corresponding to the dummy titles (like
my-awesome-product-3). This fixes that issue and the 404 on products that occur on occasion.Fixes #11831
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Please test the feature on a WooExpress install instead of Jurassic Ninja, as the latter can be very limited in terms of server resources and unstable, as other installs can interfere with your own.
/wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag:Test the CYS experience
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog