-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate express payments buttonAttributes API from the Checkout Block #3164
Conversation
Not sure about your release process or which version this will end up in so I've not edited the changelog. Let me know what you prefer here. |
It's worth noting here that it was decided to postpone the release of the One of the reasons we did this is to allow the major payment gateways to integrate with this before we ship it. So this should still be merged and released ahead of Woo Core. |
Just a note to say that the @diegocurbelo How's the review for this going? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good and it works as expected:
- Ensure the express payment method is visible there (Link, GPay or Apple Pay)
https://github.com/user-attachments/assets/5f15294c-acae-48eb-b68e-53012947e912
- Ensure the express payment method is visible there too
https://github.com/user-attachments/assets/fe44ecc3-c710-4931-811a-d8280b9a40d4
- The express payment button height should be 55px
https://github.com/user-attachments/assets/551a3e3f-db64-44d7-824c-af78e3ad80ad
- A notice should read Some appearance settings may be overridden by the express payment section of the Cart & Checkout blocks.
- Check the link takes you to the Checkout Block
It does 👍
Changes proposed in this Pull Request:
This PR uses the
buttonAttributes
API introduced in Woo Core in Add new buttonAttributes API to style express checkout buttons coherently. This will respect the newheight
andborderRadius
controls on the express checkout block, overriding extension settings when these are available. It also uses thedarkMode
setting to override the button theme.This means the Stripe specific settings are still applied if we're not in a checkout block context. But if we are, the button styles will be synced across all express payment buttons that have integrated with this API.
Note: At the moment, the borderRadius property is not available on the PRB API. This will be used once the switch is made to ECE.
Testing instructions
55px
Some appearance settings may be overridden by the express payment section of the Cart & Checkout blocks.
changelog.txt
andreadme.txt
(or does not apply)Post merge