Fix subscription processing with mandates #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Mayisha
reviewed
Aug 19, 2024
Mayisha
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Nice work This PR perfectly fixed the issue of switching variable subscriptions. @wjrosa 🎉
I have noticed a few problems while testing.
- No mandate is created when I use a saved card.
- Renewal fails when the shipping charge of the subscription order and the recurring order are different. Suppose the subscription price is 1000, the initial shipping charge is free and the recurring shipping charge is 20. Then it fails with the following error-
payment_intent_mandate_invalid This mandate can only be used for a payment of 12000. You attempted a payment of 10000.
- The text is wrong when the subscription is not editable.
Approving this PR as I can reproduce the above issues in the develop branch as well. I will create separate issues to fix them.
| @@ -87,6 +87,9 @@ public function maybe_init_subscriptions() { | |||
| */ | |||
| add_action( 'template_redirect', [ $this, 'remove_order_pay_var' ], 99 ); | |||
| add_action( 'template_redirect', [ $this, 'restore_order_pay_var' ], 101 ); | |||
|
|
|||
| // Disable editing for Indian subscriptions with mandates. Those need to be recreated as mandates does not support upgrades (due fixed amounts). | |||
| add_filter( 'wc_order_is_editable', [ $this, 'disable_subscription_edit_for_india' ], 10, 2 ); | |||
There was a problem hiding this comment.
This is a very good idea. 👍
|
Thank you, @Mayisha ! I will grab some of these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3230
Changes proposed in this Pull Request:
This PR fixes the processing of subscriptions when using mandates (i.e., when using Indian credit cards).
Testing instructions
Renewal
fix/subscriptions-switch-with-mandates)Indian Rupeewp-admin/admin.php?page=wc-settings&tab=subscriptionsdevelopbranch it should fail* You can force the renewal on the subscription details page (wp-admin) by selecting "Process renewal" in the dropdown box. @james-allan gave some tips on how to easily test this here.
Subscription edit
Indian Rupee, purchase a subscriptionchangelog.txtandreadme.txt(or does not apply)Post merge