Fix fatal error when canceling uncaptured orders due to non-expanded refunds in Stripe API response #3377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3371
Changes proposed in this Pull Request:
When we bumped the Stripe API version in 8.5.0 to
2024-06-20
we introduced the potential for a fatal error when cancelling uncaptured orders.In version
2022-11-15
, Stripe changed the default response for charges to no longer automatically expand therefunds
property.refunds
no longer expanded. Source: https://docs.stripe.com/upgrades#2022-11-15This caused a fatal error when attempting to cancel an uncaptured charge because we expected the charge object to have refund data. This PR fixes that by making sure we fetch the charge and expand the refunds array before attempting to access it.
Testing instructions
develop
you will receive the following error.changelog.txt
andreadme.txt
(or does not apply)Post merge