ECE - Set the order payment method title to the wallet used to process payments

[james-allan]

Fixes #3469

Changes proposed in this Pull Request:

This PR makes the following changes:

1. Removes code added in a previous ECE PR (Add support for ECE Payment buttons on Pay for Order page #3440) which set the payment method title when processing payments via the Pay for Order payment. This is no longer necessary because we're setting the payment method title in a more general way that will work for all pages.
2. Stripe payment method objects record the type of express payment wallet is used to process the payment (see example below). When processing a payment with wallet information, set the payment method title to the corresponding wallet type.

Stripe Payment Method object

stdClass Object
(
    [id] => pm_1Q4c4tEYkV5SNaUVCGyhKgeg
    [object] => payment_method
    [billing_details] => stdClass Object
        (
            [address] => stdClass Object
                (
                   ...
                )

            [email] => ...
            [name] => Card Holder Name
            [phone] => +1 650-555-5555
        )

    [card] => stdClass Object
        (
            [brand] => visa
            ...

            [wallet] => stdClass Object
                (
                    [dynamic_last4] => 1111
                    [google_pay] => stdClass Object
                        (
                        )

                    [type] => google_pay <------ SEE HERE
                )

        )
     ...

    [type] => card
)

Testing instructions

1. Set the ECE feature flag option (_wcstripe_feature_ece) to 'yes'.
2. Enable Express payment methods Google and Apple Pay.
3. Complete a purchase using Google and/or Apple Pay
4. Confirm on the order received page that the order's payment method title is set to Google or Apple Pay.

While working on this, I've also confirmed that standard card payments still set the title to the default Credit / Debit Card and if the title is customised, it is still set for standard card payments.

---

• Covered with tests (or have a good reason not to test in description ☝️)
• Added changelog entry in both changelog.txt and readme.txt (or does not apply)
• Tested on mobile (or does not apply)

Post merge

• Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
• Added the needs docs label (or does not apply)
• Included this PR in the Release Thread scope (or does not apply)

[Mayisha]

Nice fix James 🎉

Payment method title is correctly set as Google Pay (Stripe) when paid via ECE button. I have tested with Google Pay.

• Shortcode cart page ✅
• Shortcode checkout page ✅
• Block cart page ✅
• Block checkout page ✅
• Pay for order page ✅

Additionally I have tested with card, AliPay and CashApp. Payment method title is correctly set for them as well.

[james-allan]

Thanks for the review @Mayisha. I'm going to reopen this for review because I've made a substantial change to this PR.

The WC_Stripe_UPE_Payment_Method_CC::get_title() function previously supported passing $payment_details that could be used to alter the resulting title. If for example it was passed payment method details that indicated that the payment method was a Mastercard Credit Card the resulting order payment method would be Mastercard credit card rather than the default title.

Doing a search of the code base for ->get_title(... I wasn't able to find any instances where we were passing this addition information other than the change in this PR and in unit tests, so its safe (imo) to assume this feature was not actually being used.

That feature of customising the title to be Mastercard credit card also breaks with the customisable title that merchants can set via the settings. ie if a merchant changes the default title of the credit card payment method, then the way this code worked, it would override that to "Visa debit card".

[Mayisha]

The new changes look good and things are working perfectly.
I also had a quick search and did not find any instances where the additional information was being sent to the get_title function. 👍