Remove duplicate banner #3562
Open
Remove duplicate banner #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not about the same
|
Does this affect only the Payment Methods tab, or both Payment Methods and Settings tabs? |
@aheckler only the payment methods tab. |
Mayisha
requested review from
a team and
wjrosa
and removed request for
a team
wjrosa
reviewed
Oct 31, 2024
| <GeneralSettingsSection | ||
| onSaveChanges={ onSaveChanges } | ||
| showLegacyExperienceTransitionNotice={ | ||
| promotionalBannerType !== 'new-checkout-experience' |
There was a problem hiding this comment.
Maybe it is worth moving new-checkout-experience (and the other types) to constants.
|
Thanks for this fix, @Mayisha ! I am getting the following error when I enable the legacy checkout: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3561
When the legacy checkout is enabled, 2 different banners are displayed with a similar message.
Changes proposed in this Pull Request:
Showing 'LegacyExperienceTransitionNotice' only when the promotional banner is not about the same.
Testing instructions