-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Bacs Direct Debit payment method #3727
Conversation
72040df
to
200c3f5
Compare
@rafaelzaleski Please hold off on reviewing this PR for now. I’m currently investigating an issue I just discovered. |
False alarm. I thought the payment method was supposed to disappear when entering a billing address from an unsupported country. I could have sworn it worked that way while working on the spike. However, the payment method only disappears after entering the address and refreshing the page. I tested with another similar payment method (Cash App), and the behavior is the same, so it’s not a bug. Please review @rafaelzaleski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests well! I only left a minor request for changes related to i18n.
@asumaran, there are also failing unit tests related to the changes in this branch. |
@rafaelzaleski I'll take a look at those. |
Since it’s behind a flag it will not be available.
Closes #3751
Changes proposed in this Pull Request:
Enable checkout using Bacs Direct Debit between merchants and customers in the UK.
Testing instructions
Important
To enable Bacs Direct Debit as a payment method option, you must first activate it using the following feature flag:
wp option update _wcstripe_feature_lpm_bacs 'yes'
.Important
(assuming you are receiving webhook events correctly) – After completing the checkout and receiving the initial webhook events from Stripe, to speed up order processing, you need to manually run the scheduled action. To do this, go to Tools > Scheduled Actions, search for the
wc_stripe_deferred_webhook
hook, and click "Run". After this, the order status should change to “Processing.”Checkout using Bacs with a simple product
as-bacs
.Checkout using Bacs with a virtual product.
Verify that Bacs is not displayed as an option if the feature flag is set to
no
.wp option update _wcstripe_feature_lpm_bacs 'no'
changelog.txt
andreadme.txt
(or does not apply)Post merge