Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bacs LPM feature flag #3754

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Add Bacs LPM feature flag #3754

merged 2 commits into from
Jan 22, 2025

Conversation

asumaran
Copy link
Contributor

@asumaran asumaran commented Jan 21, 2025

Closes #3750

Changes proposed in this Pull Request:

Introduces the _wcstripe_feature_lpm_bacs flag to toggle the Bacs local payment method. It will be used in the next PR to control whether the payment method is shown or hidden.

Testing instructions

Enable Bacs

  • Switch to this branch as-bacs-feature-flag.
  • On the root path of your WP install run wp option update _wcstripe_feature_lpm_bacs 'yes' (prepend with npm run if you are using Docker)
  • Go to the Stripe Gateway settings page, then run in the browser console. window.wc_stripe_settings_params.is_bacs_enabled === '1', it should be true
  • Go to the Checkout Page then run. window.wc_stripe_upe_params.is_bacs_enabled === '1', it should be true.

Disable Bacs

  • On the root path of your WP install run wp option update _wcstripe_feature_lpm_bacs 'no'
  • Go to the Stripe Gateway settings page, then run in the browser console. window.wc_stripe_settings_params.is_bacs_enabled === '', it should be true
  • Go to the Checkout Page then run. window. wc_stripe_upe_params.is_bacs_enabled === '', it should be true.

Post merge

@asumaran asumaran self-assigned this Jan 21, 2025
@asumaran asumaran marked this pull request as ready for review January 21, 2025 18:51
Copy link
Contributor

@rafaelzaleski rafaelzaleski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asumaran asumaran merged commit 2c8a56f into develop Jan 22, 2025
33 of 37 checks passed
@asumaran asumaran deleted the as-bacs-feature-flag branch January 22, 2025 12:20
@asumaran asumaran mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bacs: Add Feature Flag
2 participants