Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal error when editing the shortcode checkout page #3758

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Fix fatal error when editing the shortcode checkout page #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c29f510
Fix fatal error when editing the shortcode checkout page
wjrosa Jan 22, 2025
75bdc09
Changelog and readme entries
wjrosa Jan 22, 2025
59ed708
Merge branch 'develop' into fix/fatal-error-editing-shortcode-checkout
wjrosa Jan 22, 2025
3fc9496
Merge branch 'develop' into fix/fatal-error-editing-shortcode-checkout
wjrosa Jan 24, 2025
e80b7c5
Merge branch 'develop' into fix/fatal-error-editing-shortcode-checkout
diegocurbelo Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*** Changelog ***

= 9.2.0 - xxxx-xx-xx =
* Fix - Fixes a fatal error when editing the shortcode checkout page with an empty cart on PHP 8.4.
* Fix - Fixes processing of orders through the Pay for Order page when using ECE with Blocks (Store) API.
* Add - Enables the use of Blocks API for Express Checkout Element orders by default.
* Add - Adds a new filter to allow changing the user attributed to an order when paying for it through the Order Pay page.
Expand Down
2 changes: 1 addition & 1 deletion includes/payment-methods/class-wc-stripe-express-checkout-helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ public function should_show_express_checkout_button() {
! $this->is_pay_for_order_page() &&
(
( is_product() && ! $this->product_needs_shipping( $this->get_product() ) ) ||
( ( is_cart() || is_checkout() ) && ! WC()->cart->needs_shipping() )
( ( is_cart() || is_checkout() ) && ( ! WC()->cart || ! WC()->cart->needs_shipping() ) )
) &&
wc_tax_enabled() &&
in_array( get_option( 'woocommerce_tax_based_on' ), [ 'billing', 'shipping' ], true )
Expand Down
1 change: 1 addition & 0 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
== Changelog ==

= 9.2.0 - xxxx-xx-xx =
* Fix - Fixes a fatal error when editing the shortcode checkout page with an empty cart on PHP 8.4.
* Fix - Fixes processing of orders through the Pay for Order page when using ECE with Blocks (Store) API.
* Add - Enables the use of Blocks API for Express Checkout Element orders by default.
* Add - Adds a new filter to allow changing the user attributed to an order when paying for it through the Order Pay page.
Expand Down
Loading