Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Pay ECE: allow continue on loaderror for other express types #3825

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

annemirasol
Copy link
Contributor

@annemirasol annemirasol commented Feb 3, 2025

Fixes an issue where other express payment types, e.g. Google Pay, do not work properly when Amazon Pay fails to load due to compatibility reasons.

Changes proposed in this Pull Request:

In #3741, we have moved to using one element per express payment type. In this PR, we allow other express payment types to keep working even when another express payment type fails to load.

For example, if Amazon Pay fails to load, e.g. due to currency incompatibility, we still want shoppers to be able to use other express payment types if they themselves have no issues.

Testing instructions

  1. Turn the feature flag on, by setting the _wcstripe_feature_amazon_pay option to yes.
  2. Enable Google Pay/Apple Pay, Link and Amazon Pay in your Stripe extension settings.
  3. With store currency as usd, verify that Google Pay/Apple Pay, Link and Amazon Pay are available in the product page.
  4. With store currency as eur, verify that Amazon Pay is no longer available after a refresh.
  5. Click on one of the other express payment buttons, e.g. Google Pay.
    • In develop, you will see a window alert saying the cart is not compatible with express checkout.
    • In this branch, you should have no problems using any of the other express types to make a purchase.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@annemirasol annemirasol changed the title Allow other express payment types to continue when others fail Amazon Pay ECE: allow continue on loaderror for other express types Feb 3, 2025
@annemirasol annemirasol mentioned this pull request Feb 3, 2025
6 tasks
Base automatically changed from add/amazon-pay-feature-flag to develop February 3, 2025 20:34
@annemirasol annemirasol marked this pull request as ready for review February 3, 2025 22:20
@annemirasol annemirasol self-assigned this Feb 3, 2025
@annemirasol annemirasol requested review from a team and diegocurbelo and removed request for a team February 3, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant