Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using filters to collect cart endpoint data using StoreAPI #3840

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Feb 5, 2025

Changes proposed in this Pull Request:

This is a simple PR that makes use of the new filter introduced in #3780 (wcstripe.express-checkout.cart-add-item) to replace some parts of the code. It is heavily inspired by the WooPayments version.

Testing instructions

  • Checkout and build this branch on your test environment (dev/implementing-filters-when-calling-cart-store-api)
  • Connect your Stripe account
  • Enable express payment methods (Google Pay, Amazon Pay, Link, Apple Pay)
  • As a shopper, access the store using a public-facing address
  • Confirm you can purchase products using the product, cart, and checkout pages. On both classic/shortcode and blocks version

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Feb 5, 2025
@wjrosa wjrosa marked this pull request as ready for review February 5, 2025 20:01
@wjrosa wjrosa requested review from a team and diegocurbelo and removed request for a team February 5, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant