Allow setting a different title for the top performers list

woocommerce · Jun 28, 2024 · 7a0c0b3 · 7a0c0b3
1 parent a0e73e4
commit 7a0c0b3
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/...Classes/ViewRelated/Dashboard/Analytics Hub/Report Cards/AnalyticsTopPerformersCard.swift b/...Classes/ViewRelated/Dashboard/Analytics Hub/Report Cards/AnalyticsTopPerformersCard.swift
@@ -37,6 +37,10 @@ struct AnalyticsTopPerformersCard: View {
     ///
     let statsErrorMessage: String
 
+    /// Title for top performers list.
+    ///
+    let topPerformersTitle: String
+
     /// Top performers data to render.
     ///
     let topPerformersData: [TopPerformersRow.Data]
@@ -90,7 +94,7 @@ struct AnalyticsTopPerformersCard: View {
                     .padding(.top, Layout.columnSpacing)
             }
 
-            TopPerformersView(itemTitle: title.localizedCapitalized,
+            TopPerformersView(itemTitle: topPerformersTitle.localizedCapitalized,
                               valueTitle: statTitle,
                               rows: topPerformersData,
                               isRedacted: isTopPerformersRedacted)
@@ -134,7 +138,8 @@ struct AnalyticsItemsSoldCardPreviews: PreviewProvider {
                                deltaTextColor: .textInverted,
                                isStatsRedacted: false,
                                showStatsError: false,
-                               statsErrorMessage: "Unable to load product analytics",
+                                   statsErrorMessage: "Unable to load product analytics",
+                                   topPerformersTitle: "Products",
                                topPerformersData: [
                                 .init(imageURL: imageURL, name: "Tabletop Photos", details: "Net Sales: $1,232", value: "32"),
                                 .init(imageURL: imageURL, name: "Kentya Palm", details: "Net Sales: $800", value: "10"),
@@ -160,6 +165,7 @@ struct AnalyticsItemsSoldCardPreviews: PreviewProvider {
                                isStatsRedacted: false,
                                showStatsError: true,
                                statsErrorMessage: "Unable to load product analytics",
+                                   topPerformersTitle: "Products",
                                topPerformersData: [],
                                isTopPerformersRedacted: false,
                                showTopPerformersError: true,

diff --git a/...Classes/ViewRelated/Dashboard/Analytics Hub/Report Cards/BundlesReportCardViewModel.swift b/...Classes/ViewRelated/Dashboard/Analytics Hub/Report Cards/BundlesReportCardViewModel.swift
@@ -158,6 +158,7 @@ extension AnalyticsTopPerformersCard {
         self.reportViewModel = bundlesViewModel.reportViewModel
 
         // Top performers list
+        self.topPerformersTitle = bundlesViewModel.title
         self.topPerformersData = bundlesViewModel.bundlesSoldData
         self.isTopPerformersRedacted = bundlesViewModel.isRedacted
         self.showTopPerformersError = bundlesViewModel.showBundlesSoldError

diff --git a/...ewRelated/Dashboard/Analytics Hub/Report Cards/GoogleAdsCampaignReportCardViewModel.swift b/...ewRelated/Dashboard/Analytics Hub/Report Cards/GoogleAdsCampaignReportCardViewModel.swift
@@ -78,6 +78,12 @@ extension GoogleAdsCampaignReportCardViewModel {
 
     // MARK: Campaigns report
 
+    /// Title for campaigns list.
+    ///
+    var campaignsTitle: String {
+        Localization.campaignsTitle
+    }
+
     /// Campaigns data to render.
     ///
     var campaignsData: [TopPerformersRow.Data] {
@@ -148,6 +154,7 @@ extension AnalyticsTopPerformersCard {
         self.reportViewModel = campaignsViewModel.reportViewModel
 
         // Top performers (campaigns) list
+        self.topPerformersTitle = campaignsViewModel.campaignsTitle
         self.topPerformersData = campaignsViewModel.campaignsData
         self.isTopPerformersRedacted = campaignsViewModel.isRedacted
         self.showTopPerformersError = campaignsViewModel.showCampaignsError
@@ -164,6 +171,9 @@ private extension GoogleAdsCampaignReportCardViewModel {
         static let title = NSLocalizedString("analyticsHub.googleCampaigns.title",
                                              value: "Google Campaigns",
                                              comment: "Title for the Google campaigns card on the analytics hub screen.").localizedUppercase
+        static let campaignsTitle = NSLocalizedString("analyticsHub.googleCampaigns.campaignsList.title",
+                                                      value: "Campaigns",
+                                                      comment: "Title for the list of campaigns on the Google campaigns card on the analytics hub screen.")
         static let totalSales = NSLocalizedString("analyticsHub.googleCampaigns.totalSalesTitle",
                                                   value: "Total Sales",
                                                   comment: "Title for the Total Sales column on the Google Ads campaigns card on the analytics hub screen.")

diff --git a/...lasses/ViewRelated/Dashboard/Analytics Hub/Report Cards/ProductsReportCardViewModel.swift b/...lasses/ViewRelated/Dashboard/Analytics Hub/Report Cards/ProductsReportCardViewModel.swift
@@ -171,6 +171,7 @@ extension AnalyticsTopPerformersCard {
         self.reportViewModel = statsViewModel.reportViewModel
 
         // Top performers list
+        self.topPerformersTitle = statsViewModel.title
         self.topPerformersData = itemsViewModel.itemsSoldData
         self.isTopPerformersRedacted = itemsViewModel.isRedacted
         self.showTopPerformersError = itemsViewModel.showItemsSoldError