[SiOC - customer creation] Disable feature flag as the feature is pau…

…sed (#14363)
woocommerce · Nov 12, 2024 · 9a9b909 · 9a9b909
2 parents cb4e6bd + 3df8ec4
commit 9a9b909
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/Experiments/Experiments/DefaultFeatureFlagService.swift b/Experiments/Experiments/DefaultFeatureFlagService.swift
@@ -69,7 +69,8 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
         case .subscriptionsInOrderCreationUI:
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .subscriptionsInOrderCreationCustomers:
-            return (buildConfig == .localDeveloper || buildConfig == .alpha) && !isUITesting
+            // Feature paused pfoUAQ-zw-p2#comment-510.
+            return false
         case .pointOfSale:
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .googleAdsCampaignCreationOnWebView:

diff --git a/WooCommerce/WooCommerceTests/ViewRelated/Orders/Order Details/EditOrderFormTests.swift b/WooCommerce/WooCommerceTests/ViewRelated/Orders/Order Details/EditOrderFormTests.swift
@@ -18,7 +18,7 @@ final class EditOrderFormTests: XCTestCase {
         // Then
         XCTAssertNotNil(try? sut.find(button: "Add Products"))
         XCTAssertNotNil(try? sut.find(button: "Add Custom Amount"))
-        XCTAssertNotNil(try? sut.find(button: "Add Customer"))
+        XCTAssertNotNil(try? sut.find(button: "Add Customer Details"))
         XCTAssertNotNil(try? sut.find(button: "Add Note"))
         XCTAssertNotNil(try? sut.find(button: "Done"))
     }
@@ -38,7 +38,7 @@ final class EditOrderFormTests: XCTestCase {
         XCTAssertNotNil(try? sut.find(button: "Add Custom Amount"))
         XCTAssertNotNil(try? sut.find(button: "Add Shipping"))
         XCTAssertNotNil(try? sut.find(button: "Add Coupon"))
-        XCTAssertNotNil(try? sut.find(button: "Add Customer"))
+        XCTAssertNotNil(try? sut.find(button: "Add Customer Details"))
         XCTAssertNotNil(try? sut.find(button: "Add Note"))
         XCTAssertNotNil(try? sut.find(button: "Done"))
     }
@@ -56,7 +56,7 @@ final class EditOrderFormTests: XCTestCase {
 
         XCTAssertNotNil(try? sut.find(viewWithAccessibilityLabel: "Edit amount"))
         XCTAssertNotNil(try? sut.find(button: "Add Shipping"))
-        XCTAssertNotNil(try? sut.find(button: "Add Customer"))
+        XCTAssertNotNil(try? sut.find(button: "Add Customer Details"))
         XCTAssertNotNil(try? sut.find(button: "Add Note"))
         XCTAssertNotNil(try? sut.find(button: "Done"))
     }
@@ -74,7 +74,7 @@ final class EditOrderFormTests: XCTestCase {
         XCTAssertNotNil(try? sut.find(text: "Order total"))
 
         XCTAssertNotNil(try? sut.find(viewWithAccessibilityLabel: "Edit shipping"))
-        XCTAssertNotNil(try? sut.find(viewWithAccessibilityLabel: "Search customer"))
+        XCTAssertNotNil(try? sut.find(viewWithAccessibilityLabel: "Edit Customer Details"))
 
         XCTAssertNotNil(try? sut.find(button: "Add Products"))
         XCTAssertNotNil(try? sut.find(button: "Add Custom Amount"))
@@ -97,7 +97,7 @@ final class EditOrderFormTests: XCTestCase {
 
         XCTAssertNotNil(try? sut.find(button: "Add Products"))
         XCTAssertNotNil(try? sut.find(button: "Add Custom Amount"))
-        XCTAssertNotNil(try? sut.find(button: "Add Customer"))
+        XCTAssertNotNil(try? sut.find(button: "Add Customer Details"))
         XCTAssertNotNil(try? sut.find(button: "Done"))
     }
 }
@@ -107,6 +107,7 @@ private extension EditOrderFormTests {
     static func createEditView(with order: Order) -> OrderForm {
         let stores = MockStoresManager(sessionManager: .testingInstance)
         let storage = MockStorageManager()
+        let featureFlagService = MockFeatureFlagService(isSubscriptionsInOrderCreationCustomersEnabled: false)
 
         // Insert products that relates to items into the storage.
         // This is needed by EditableOrderViewModel to properly compute its variables
@@ -118,7 +119,8 @@ private extension EditOrderFormTests {
         let viewModel = EditableOrderViewModel(siteID: order.siteID,
                                                flow: .editing(initialOrder: order),
                                                stores: stores,
-                                               storageManager: storage)
+                                               storageManager: storage,
+                                               featureFlagService: featureFlagService)
         return OrderForm(flow: .editing, viewModel: viewModel, presentProductSelector: {})
     }