-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Ads: Integrate connection check endpoint on Networking layer #13140
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 🚀
I left a question about making this request work for application password login.
|
||
public func checkConnection(for siteID: Int64) async throws -> GoogleAdsConnection { | ||
let path = Paths.connection | ||
let request = JetpackRequest(wooApiVersion: .none, method: .get, siteID: siteID, path: path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Should we specify availableAsRESTRequest
as true
?
I am asking based on the GoogleAdsConnectionMapper
being able to parse both with/without data envelope JSON responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! I added support for REST request in a85b3f8.
Part of #13139
Description
This PR updates the Networking layer to integrate the endpoint to check the connection of a given site with Google Ads plugin. Changes include:
GET wc/gla/ads/connection
.Yosemite update will be done in a separate PR.
Testing steps
Just CI passing should be sufficient.
Screenshots
N/A
RELEASE-NOTES.txt
if necessary.