[Product Creation AI v2] Add Starting information screen #13171

selanthiraiyan · 2024-06-26T15:53:00Z

Part of: #13104

Description

As part of the Product Creation AI v2 work this PR Adds initial version for "Starting information" screen.

Changes

Remove the previous feature flag using for Product Creation AI v1.
View and ViewModel for Starting information" screen.
Show "Starting information" screen after checking feature flag.
Hide the progress bar after checking feature flag.
Navigate to product preview screen from "Starting information" screen.

Steps to reproduce

Create a JN site with Jetpack AI plugin
Turn on productCreationAIv2M1 feature flag
Build and run the app
Navigate to the products tab
Tap + button on top right
Tap "Create a product with AI"
Validate that the new "Starting information" screen is displayed.
Stop the app.
Disable the productCreationAIv2M1 feature flag and build and run the app.
Repeat steps 4 to 6.
Validate that the previous "Add product name" screen is displayed.

Testing information

Test the product creation with AI flow works as before when productCreationAIv2M1 feature flag turned off.

Screenshots

`productCreationAIv2M1` false	`productCreationAIv2M1` true

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

dangermattic · 2024-06-26T15:53:35Z

	1 Warning
⚠️	This PR is assigned to the milestone 19.3. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

wpmobilebot · 2024-06-26T16:08:09Z

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr13171-af63414
	Version	19.2
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	`af63414`
	App Center Build	WooCommerce - Prototype Builds #9771

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

itsmeichigo

This works as expected. I found an issue with back navigation from the Preview screen, which shows a deprecated screen, but please feel free to handle that in a separate PR.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-27.at.12.12.04.mp4

itsmeichigo · 2024-06-27T05:07:45Z

...ted/Products/Add Product/AddProductWithAI/Container/AddProductWithAIContainerViewModel.swift

@@ -23,6 +24,7 @@ final class AddProductWithAIContainerViewModel: ObservableObject {

    let siteID: Int64
    let source: AddProductCoordinator.Source
+    let featureFlagService: FeatureFlagService


Super nit: is this for use later or redundant? I don't see it being used in this file.

Thanks. I have started using this featureFlagService now.

itsmeichigo · 2024-06-27T05:09:17Z

...ted/Products/Add Product/AddProductWithAI/Container/AddProductWithAIContainerViewModel.swift

+    private(set) lazy var startingInfoViewModel: ProductCreationAIStartingInfoViewModel = {
+        .init(siteID: siteID)
+    }()


Nit: we should migrate away from .init(...) as a direct init would perform better.

Suggested change

private(set) lazy var startingInfoViewModel: ProductCreationAIStartingInfoViewModel = {

.init(siteID: siteID)

}()

private(set) lazy var startingInfoViewModel = ProductCreationAIStartingInfoViewModel(siteID: siteID)

Done in 1874e8b

itsmeichigo · 2024-06-27T05:17:12Z

...d/Products/Add Product/AddProductWithAI/StartingInfo/ProductCreationAIStartingInfoView.swift

+                    Image(systemName: Layout.UsePackagePhoto.cameraSFSymbol)
+                        .renderingMode(.template)
+                        .fontWeight(.semibold)
+                        .foregroundColor(Color(.brand))


Super nit: I'd suggest using Color.accentColor just in case we decide to change the accent color or brand color to be different. We should use brand color only for components that are directly related to our branding IMO.

Thanks, Huong! Updated in 11e6e9a

itsmeichigo · 2024-06-27T05:18:25Z

...d/Products/Add Product/AddProductWithAI/StartingInfo/ProductCreationAIStartingInfoView.swift

+    enum Localization {
+        static let title = NSLocalizedString(
+            "Starting information",
+            comment: "Title on the starting info screen."
+        )
+        static let subtitle = NSLocalizedString(
+            "Tell us about your product, what it is and what makes it unique, then let the AI work its magic.",
+            comment: "Subtitle on the starting info screen."
+        )
+        static let placeholder = NSLocalizedString(
+            "For example: Black cotton t-shirt, soft fabric, durable stitching, unique design",
+            comment: "Placeholder text on the product features field"
+        )
+        static let readTextFromPhoto = NSLocalizedString(
+            "Read text from product photo",
+            comment: "Upload package photo button on the text field"
+        )
+        static let continueText = NSLocalizedString(
+            "Continue",
+            comment: "Continue button on the starting info screen."
+        )
+    }


Should we follow the latest naming style for localized strings with separate keys and values?

Good point. Done in 1307d5d

selanthiraiyan · 2024-06-27T07:42:52Z

Thanks for the review, Huong! 🙇

I found an issue with back navigation from the Preview screen, which shows a deprecated screen, but please feel free to handle that in a separate PR.

Good catch. I have fixed this in c88adcc

I am enabling auto-merge now. Kindly add comments, if any.

selanthiraiyan added 9 commits June 26, 2024 19:15

Stop checking for product creation AI feature flag.

62eb722

Remove unused product creation AI feature flag.

7b231ea

Inject feature flag service.

62acd82

Hide progress view for v2.

805a47f

Add view model for starting info screen.

fae7c9b

Add view for starting info screen.

cff60ba

Property to hold starting info view model.

a6316e2

Show starting info screen if feature flag is on.

0befee3

Merge branch 'trunk' into feat/13104-starting-info-view

01bce07

selanthiraiyan added the feature: add/edit products Related to adding or editing products. label Jun 26, 2024

selanthiraiyan added this to the 19.3 milestone Jun 26, 2024

selanthiraiyan added 2 commits June 26, 2024 21:26

Remove unused layout constant.

97623ab

Update string comment.

dc112fb

selanthiraiyan requested review from pmusolino and itsmeichigo June 26, 2024 16:11

selanthiraiyan marked this pull request as ready for review June 26, 2024 16:11

selanthiraiyan mentioned this pull request Jun 26, 2024

Image selection #13104

Closed

3 tasks

itsmeichigo self-assigned this Jun 27, 2024

itsmeichigo approved these changes Jun 27, 2024

View reviewed changes

selanthiraiyan added 7 commits June 27, 2024 12:55

Add property for reading product features from container view model.

626aa1f

Update init methods.

1874e8b

Change back navigation after checking feature flag.

c88adcc

Check product features for interactive dismissal.

e053fef

Use accent color.

11e6e9a

Update naming style of localized strings.

1307d5d

Merge branch 'trunk' into feat/13104-starting-info-view

8c7747f

Refactor code for checking back navigation.

7c02e11

Update unit tests to mock isProductCreationAIv2M1Enabled as false.

af63414

selanthiraiyan merged commit b9aacc5 into trunk Jun 27, 2024
22 checks passed

selanthiraiyan deleted the feat/13104-starting-info-view branch June 27, 2024 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Product Creation AI v2] Add Starting information screen #13171

[Product Creation AI v2] Add Starting information screen #13171

selanthiraiyan commented Jun 26, 2024

dangermattic commented Jun 26, 2024 •

edited

Loading

wpmobilebot commented Jun 26, 2024 •

edited

Loading

itsmeichigo left a comment

itsmeichigo Jun 27, 2024

selanthiraiyan Jun 27, 2024

itsmeichigo Jun 27, 2024

selanthiraiyan Jun 27, 2024

itsmeichigo Jun 27, 2024

selanthiraiyan Jun 27, 2024

itsmeichigo Jun 27, 2024

selanthiraiyan Jun 27, 2024

selanthiraiyan commented Jun 27, 2024

[Product Creation AI v2] Add Starting information screen #13171

[Product Creation AI v2] Add Starting information screen #13171

Conversation

selanthiraiyan commented Jun 26, 2024

Description

Steps to reproduce

Testing information

Screenshots

dangermattic commented Jun 26, 2024 • edited Loading

wpmobilebot commented Jun 26, 2024 • edited Loading

itsmeichigo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

selanthiraiyan commented Jun 27, 2024

dangermattic commented Jun 26, 2024 •

edited

Loading

wpmobilebot commented Jun 26, 2024 •

edited

Loading