Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Ads: Update Yosemite to support fetching ads campaigns #13189

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Google Ads: Update Yosemite to support fetching ads campaigns #13189

merged 3 commits into from
Jun 28, 2024

Conversation

itsmeichigo
Copy link
Contributor

Closes: #13182

Description

This PR updates GoogleAdsStore and GoogleAdsAction to support fetching ads campaigns.

Testing

  • Just CI passing is sufficent.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added the type: task An internally driven task. label Jun 28, 2024
@itsmeichigo itsmeichigo added this to the 19.4 milestone Jun 28, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13189-a1627ba
Version19.2
Bundle IDcom.automattic.alpha.woocommerce
Commita1627ba
App Center BuildWooCommerce - Prototype Builds #9789
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo changed the title Google Listings & Ads: Update Yosemite to support fetching ads campaigns Google Ads: Update Yosemite to support fetching ads campaigns Jun 28, 2024
@itsmeichigo itsmeichigo added the feature: google-ads-campaigns Related to Google ads campaigns label Jun 28, 2024
@selanthiraiyan selanthiraiyan self-assigned this Jun 28, 2024
selanthiraiyan
selanthiraiyan approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@itsmeichigo itsmeichigo merged commit d77c8db into trunk Jun 28, 2024
30 of 31 checks passed
@itsmeichigo itsmeichigo deleted the task/13182-yosemite-fetch-gla-campaigns branch June 28, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selanthiraiyan selanthiraiyan selanthiraiyan approved these changes

@pmusolino pmusolino Awaiting requested review from pmusolino

Assignees

@selanthiraiyan selanthiraiyan

Labels
feature: google-ads-campaigns Related to Google ads campaigns type: task An internally driven task.
Projects
None yet
Milestone
19.4
Development

Successfully merging this pull request may close these issues.

Fetch campaign list
3 participants
@itsmeichigo @wpmobilebot @selanthiraiyan