Product Creation with AI: update prompt to generate 3 options #13258
Conversation
…ue to an unexpectedly low `max_tokens` limit. Updated the code to explicitly set `max_tokens` to 4000, ensuring full-length responses for detailed prompts.
pmusolino
added
type: enhancement
|
|
| return ["name": "The name of the product, written in the language with ISO code ```\(language)```", | ||
| "description": "Product description of around 100 words long in a ```\(tone)``` tone, " | ||
| return ["names": "An array of strings, containing three different names of the product, written in the language with ISO code ```\(language)```", | ||
| "descriptions": "An array of strings, each containing three different product descriptions of around 100 words long each in a ```\(tone)``` tone, " | ||
| + "written in the language with ISO code ```\(language)```", | ||
| "short_description": "Product's short description, written in the language with ISO code ```\(language)```", |
There was a problem hiding this comment.
Internal - p1720090796407329-slack-C03L1NF1EA3
We decided to add the "Short description" field to the product preview screen. Hence, we need to ask the three options for the short_description field as well.
There was a problem hiding this comment.
I logged a subtask here. I will work on this.
| @@ -125,7 +125,7 @@ public extension Product { | |||
| tags: [ProductTag]) { | |||
| self.init(siteID: siteID, | |||
| productID: 0, | |||
| name: aiProduct.name, | |||
| name: aiProduct.names.first ?? "", | |||
There was a problem hiding this comment.
Not a blocker, and we can add it in a future PR:
I think we should add another helper method to init a Product with a custom selected name, description and shortDescription. We can use the new custom init method to pass the user selected/typed name, description and shortDescription.
pmusolino
deleted the
issue/13108-update-ai-prompt-to-generate-3-options-for-product-name-and-description
branch
Closes: #13108
Description
This PR addresses issue #13108, which is part of the "Product Creation with AI: v2 - Milestone 1" (#13103). The goal is to refine the product creation prompt to yield three options for both the product name and description while ensuring compatibility with the existing product creation flow.
Changes include:
AIProductmodel to work with the previous and new flow, to store multiple name and description options.In the course of this update, I led to the decision to avoid duplicating the
AIProductmodel and related code as originally planned in the issue. Instead, I updated the existingAIProductmodel to contain arrays for names and descriptions. This approach simplifies the transition and future code maintenance, and it will require just removing 3 lines of legacy code (marked withTODO) in the future.Additionally, while working on the new prompt, I encountered token limitations in the ChatGPT responses, where the
finish_reasonwas set tolength. This indicated that the responses were being cut off due to themax_tokenslimit. To resolve this, I have manually set themax_tokensparameter to4000, which aligns with the capabilities of GPT-4o and ensures complete responses. This change will require a corresponding update on the Android client to accommodate the larger token count. More context here pe5sF9-2UYTesting
productCreationAIv2M1feature flag, and make sure the previous AI flow works as before.RELEASE-NOTES.txtif necessary.