-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance error logging in OrderDetailsDataSource
#14018
Enhance error logging in OrderDetailsDataSource
#14018
Conversation
- Add crash logging for invalid shippingLabelIndex in OrderDetailsDataSource.swift - Add crash logging for invalid row index for shippingLabel in OrderDetailsDataSource.swift - Add crash logging for invalid section in numberOfRowsInSection in OrderDetailsDataSource.swift - Add crash logging for invalid section and row in cellForRowAtIndexPath in OrderDetailsDataSource.swift - Add crash logging for invalid section in viewForHeaderInSection in OrderDetailsDataSource.swift
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that I can't trigger the issues in the Simulator or real device, I:
- checked the code
- tested Order Details's features.
All good as far as I can check.
Found an unrelated UI issue, reported in:
Version |
Part of #13853
Description
This update enhances the error logging within the
OrderDetailsDataSource
class to improve crash diagnostics. The changes ensure that invalid indices and sections are logged for better debugging and error tracking.Summary of changes
shippingLabelIndex
.shippingLabel
.numberOfRowsInSection
.cellForRowAtIndexPath
.viewForHeaderInSection
.RELEASE-NOTES.txt
to reflect the new changes and enhancements.Steps to reproduce
OrderDetailsDataSource
class. However, this could be complicated, as we have rarely if ever been able to replicate this crash.Testing information
Please, smoke testing the Order Detail section to make sure everything works like before.
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: